r56329 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56328‎ | r56329 | r56330 >
Date:19:56, 14 September 2009
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up to r56324 per IRC comments by Nikerabbit: coding style updated
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -593,11 +593,11 @@
594594 if ( $msgKey ) {
595595 $s = '<div class="mw-warning-with-logexcerpt">';
596596
597 - if ( sizeof( $msgKey ) == 1 ) {
 597+ if ( count( $msgKey ) == 1 ) {
598598 $s .= wfMsgExt( $msgKey[0], array('parse') );
599599 } else { // Process additional arguments
600600 $args = $msgKey;
601 - unset( $args[0] );
 601+ array_shift( $args );
602602 $s .= wfMsgExt( $msgKey[0], array('parse'), $args );
603603 }
604604 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56324Support GENDER in 'renameuser-renamed-notice', changing LogEventsList::showLo...siebrand18:58, 14 September 2009

Status & tagging log