r56274 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56273‎ | r56274 | r56275 >
Date:17:43, 13 September 2009
Author:happy-melon
Status:deferred
Tags:
Comment:
Follow-up to r56256, per comments in code review
Modified paths:
  • /branches/happy-melon/phase3/includes/Login.php (modified) (history)
  • /branches/happy-melon/phase3/includes/specials/SpecialCreateAccount.php (modified) (history)

Diff [purge]

Index: branches/happy-melon/phase3/includes/Login.php
@@ -96,7 +96,7 @@
9797 public function attemptLogin(){
9898
9999 $code = $this->authenticateUserData();
100 - if( $code != self::SUCCESS ){
 100+ if( $code !== self::SUCCESS ){
101101 return $code;
102102 }
103103
@@ -482,7 +482,7 @@
483483 : self::SUCCESS;
484484 }
485485 }
486 - return true;
 486+ return self::SUCCESS;
487487 }
488488
489489 /**
Index: branches/happy-melon/phase3/includes/specials/SpecialCreateAccount.php
@@ -249,7 +249,7 @@
250250 global $wgOut;
251251 $self = SpecialPage::getTitleFor( 'Userlogin' );
252252 $wgOut->setPageTitle( wfMsgHtml( 'accountcreated' ) );
253 - $wgOut->addHTML( wfMsgWikiHtml( 'accountcreatedtext', $this->mLogin->mUser->getName() ) );
 253+ $wgOut->addWikiMsg( 'accountcreatedtext', $this->mLogin->mUser->getName() );
254254 $wgOut->returnToMain( false, $self );
255255 return true;
256256 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56256Lots of tweaks to the Login rewrite stuffhappy-melon12:51, 13 September 2009

Status & tagging log