r56247 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56246‎ | r56247 | r56248 >
Date:21:29, 12 September 2009
Author:catrope
Status:ok
Tags:
Comment:
Suggestions plugin: (bug 20617) Clicking a suggestion doesn't work
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.suggestions.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.suggestions.js
@@ -187,6 +187,10 @@
188188 $.suggestions.restore( context );
189189 } else {
190190 context.data.$textbox.val( result.data( 'text' ) );
 191+
 192+ // .val() doesn't call any event handlers, so
 193+ // let the world know what happened
 194+ context.data.$textbox.change();
191195 }
192196 }
193197 $.suggestions.special( context );
@@ -316,7 +320,7 @@
317321 if ( $result.get( 0 ) != $other.get( 0 ) ) {
318322 return;
319323 }
320 - highlight( $result, true );
 324+ $.suggestions.highlight( context, $result, true );
321325 context.data.$container.hide();
322326 if ( typeof context.config.result.select == 'function' ) {
323327 context.config.result.select.call( $result, context.data.$textbox );

Follow-up revisions

RevisionCommit summaryAuthorDate
r56248EditToolbar: (bug 20618) Stop the link dialog from inserting links to empty t...catrope21:40, 12 September 2009

Status & tagging log