r56221 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56220‎ | r56221 | r56222 >
Date:08:25, 12 September 2009
Author:raymond
Status:ok
Tags:
Comment:
Follow-up r56215: Replace hardcoded text with a new message.
Replace "images" with the generic "files"
Wrap message into a div with class=error
Add it to RELEASE-NOTES
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUndelete.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1386,6 +1386,7 @@
13871387 'filedelete-reason-otherlist',
13881388 'filedelete-reason-dropdown',
13891389 'filedelete-edit-reasonlist',
 1390+ 'filedelete-maintenance',
13901391 ),
13911392 'mimesearch' => array(
13921393 'mimesearch',
Index: trunk/phase3/includes/ImagePage.php
@@ -723,7 +723,7 @@
724724 global $wgUploadMaintenance;
725725 if( $wgUploadMaintenance && $this->mTitle && $this->mTitle->getNamespace() == NS_FILE ) {
726726 global $wgOut;
727 - $wgOut->addWikiText('Deletion and restoration of images temporarily disabled during maintenance.' );
 727+ $wgOut->wrapWikiMsg( "<div class='error'>\n$1</div>\n", array( 'filedelete-maintenance' ) );
728728 return;
729729 }
730730
Index: trunk/phase3/includes/DefaultSettings.php
@@ -4223,5 +4223,7 @@
42244224 */
42254225 $wgUseAJAXCategories = false;
42264226
4227 -// to disable image delete/restore temporarily
 4227+/**
 4228+ * To disable file delete/restore temporarily
 4229+ */
42284230 $wgUploadMaintenance = false;
Index: trunk/phase3/includes/specials/SpecialUndelete.php
@@ -648,7 +648,7 @@
649649 if( $this->mRestore && $this->mAction == "submit" ) {
650650 global $wgUploadMaintenance;
651651 if( $wgUploadMaintenance && $this->mTargetObj && $this->mTargetObj->getNamespace() == NS_FILE ) {
652 - $wgOut->addWikiText('Deletion and restoration of images temporarily disabled during maintenance.' );
 652+ $wgOut->wrapWikiMsg( "<div class='error'>\n$1</div>\n", array( 'filedelete-maintenance' ) );
653653 return;
654654 }
655655 return $this->undelete();
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2264,6 +2264,7 @@
22652265 ** Copyright violation
22662266 ** Duplicated file',
22672267 'filedelete-edit-reasonlist' => 'Edit delete reasons',
 2268+'filedelete-maintenance' => 'Deletion and restoration of files temporarily disabled during maintenance.',
22682269
22692270 # MIME search
22702271 'mimesearch' => 'MIME search',
Index: trunk/phase3/RELEASE-NOTES
@@ -85,6 +85,8 @@
8686 was denied to users(img_auth only)
8787 * (bug 19646) $wgImgAuthPublicTest added to test to see if img_auth set up
8888 correctly (img_auth only)
 89+* $wgUploadMaintenance added to disable file deletions and restorations during
 90+ maintenance
8991
9092 === New features in 1.16 ===
9193

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56215Forward-port image manipulation disabling hack from wmf-deployment r53386....brion23:36, 11 September 2009

Status & tagging log