r56131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56130‎ | r56131 | r56132 >
Date:12:25, 10 September 2009
Author:catrope
Status:deferred
Tags:
Comment:
Bump style version for r56126, minor cleanup
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/suggestions.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.suggestions.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -60,7 +60,7 @@
6161 array( 'src' => 'js/plugins/jquery.browser.js', 'version' => 3 ),
6262 array( 'src' => 'js/plugins/jquery.cookie.js', 'version' => 3 ),
6363 array( 'src' => 'js/plugins/jquery.namespaceSelect.js', 'version' => 0 ),
64 - array( 'src' => 'js/plugins/jquery.suggestions.js', 'version' => 1 ),
 64+ array( 'src' => 'js/plugins/jquery.suggestions.js', 'version' => 2 ),
6565 array( 'src' => 'js/plugins/jquery.textSelection.js', 'version' => 9 ),
6666 array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 4 ),
6767 array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 11 ),
Index: trunk/extensions/UsabilityInitiative/css/suggestions.css
@@ -34,7 +34,6 @@
3535 margin: 0;
3636 }
3737 .suggestions-result {
38 - /*white-space: nowrap;*/
3938 color: black;
4039 color: WindowText;
4140 padding: 0.25em 0.25em;
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.suggestions.js
@@ -268,7 +268,7 @@
269269 } else if ( typeof args[0] == 'string' ) {
270270 if ( args.length > 1 ) {
271271 // Set property values
272 - $.suggestions.configure( context, args[0], args[1] );;
 272+ $.suggestions.configure( context, args[0], args[1] );
273273 } else if ( returnValue == null ) {
274274 // Get property values, but don't give access to internal data - returns only the first
275275 returnValue = ( args[0] in context.config ? undefined : context.config[args[0]] );
@@ -300,7 +300,7 @@
301301 .mouseover( function( e ) {
302302 $.suggestions.highlight( context, $( e.target ).closest( '.suggestions-results div' ), false );
303303 } )
304 - .addClass( 'suggestions' ) // TODO: use own CSS
 304+ .addClass( 'suggestions' )
305305 .append(
306306 $( '<div />' ).addClass( 'suggestions-results' )
307307 // Can't use click() because the container div is hidden when the textbox loses focus. Instead,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56126Totally refactored suggestions code.tparscal00:20, 10 September 2009

Status & tagging log