r56111 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56110‎ | r56111 | r56112 >
Date:21:06, 9 September 2009
Author:dale
Status:deferred
Tags:
Comment:
restored animations for tab open close
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
@@ -114,7 +114,11 @@
115115 }
116116 }
117117 },
 118+ modifyTool : function( context, data ){
 119+
 120+ },
118121 removeFromToolbar : function( context, data ) {
 122+ js_log("f:removeFromToolbar");
119123 if ( typeof data.section == 'string' ) {
120124 // Section
121125 var tab = 'div.tabs span[rel=' + data.section + '].tab';
@@ -150,6 +154,7 @@
151155 // Just a section, remove the tab too!
152156 context.modules.$toolbar.find( tab ).remove();
153157 }
 158+ js_log('target is: ' + target);
154159 context.modules.$toolbar.find( target ).remove();
155160 }
156161 }
@@ -450,10 +455,10 @@
451456 $(this).data( 'context' ).$ui.find( '.section-' + $(this).parent().attr( 'rel' ) );
452457 $(this).blur();
453458 var show = $section.css( 'display' ) == 'none';
454 - $section.parent().children().hide();
 459+ $section.parent().children().hide("fast");
455460 $(this).parent().parent().find( 'a' ).removeClass( 'current' );
456461 if ( show ) {
457 - $section.show();
 462+ $section.show("fast");
458463 $(this).addClass( 'current' );
459464 }
460465

Status & tagging log