r56093 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56092‎ | r56093 | r56094 >
Date:14:42, 9 September 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix some minor bugs with merges
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)
  • /trunk/extensions/LiquidThreads/pages/SpecialMergeThread.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
@@ -421,6 +421,10 @@
422422 background-position: left center !important;
423423 }
424424
 425+.lqt-command-merge-to {
 426+ margin-left: 8px;
 427+}
 428+
425429 .lqt-command-link a {
426430 background-image: url(icons/link.png) !important;
427431 padding-left: 26px;
Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -509,7 +509,10 @@
510510 if ( $this->user->isAllowed( 'lqt-merge' ) ) {
511511 $mergeParams = $_GET;
512512 $mergeParams['lqt_merge_from'] = $thread->id();
513 - $mergeUrl = $thread->title()->getFullURL( wfArrayToCGI( $mergeParams ) );
 513+
 514+ unset($mergeParams['title']);
 515+
 516+ $mergeUrl = $this->title->getFullURL( wfArrayToCGI( $mergeParams ) );
514517 $label = wfMsgExt( 'lqt-thread-merge', 'parseinline' );
515518
516519 $commands['merge'] = array( 'label' => $label,
Index: trunk/extensions/LiquidThreads/pages/SpecialMergeThread.php
@@ -92,8 +92,11 @@
9393 $this->recursiveSet( $srcThread, $newSubject, $dstThread, $dstThread );
9494
9595 $dstThread->addReply( $srcThread );
96 - $oldParent->removeReply( $srcThread );
9796
 97+ if ($oldParent) {
 98+ $oldParent->removeReply( $srcThread );
 99+ }
 100+
98101 $oldTopThread->commitRevision( Threads::CHANGE_MERGED_FROM, $srcThread, $reason );
99102 $dstThread->commitRevision( Threads::CHANGE_MERGED_TO, $srcThread, $reason );
100103

Status & tagging log