r56079 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56078‎ | r56079 | r56080 >
Date:23:41, 8 September 2009
Author:yaron
Status:deferred
Tags:
Comment:
PHP fix
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormInputs.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormInputs.inc
@@ -555,6 +555,8 @@
556556 static function radioButtonHTML($cur_value, $input_name, $is_mandatory, $is_disabled, $other_args) {
557557 global $sfgTabIndex, $sfgFieldNum;
558558
 559+ $input_id = "input_$sfgFieldNum";
 560+ $info_id = "info_$sfgFieldNum";
559561 $disabled_text = ($is_disabled) ? "disabled" : "";
560562 $check_set = false;
561563 $text = "";
@@ -567,8 +569,6 @@
568570 // and there's a current value in place (either through a default value
569571 // or because we're editing an existing page)
570572 if (! $is_mandatory || $cur_value == '') {
571 - $input_id = "input_$sfgFieldNum";
572 - $info_id = "info_$sfgFieldNum";
573573 $text .= ' <input type="radio" id="' . $input_id . '" tabindex="' . $sfgTabIndex . '" name="' . $input_name . '" value=""';
574574 if (! $cur_value) {
575575 $text .= ' checked="checked"';

Status & tagging log