r56055 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56054‎ | r56055 | r56056 >
Date:18:17, 8 September 2009
Author:tparscal
Status:ok
Tags:
Comment:
In response to bug #20550 - this makes the IDs of portlets more consistent.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -692,7 +692,7 @@
693693 switch ( $element ) {
694694 case 'NAMESPACES':
695695 ?>
696 -<div id="namespaces" class="vectorTabs<?php if ( count( $this->data['namespace_urls'] ) == 0 ) echo ' emptyPortlet'; ?>">
 696+<div id="p-namespaces" class="vectorTabs<?php if ( count( $this->data['namespace_urls'] ) == 0 ) echo ' emptyPortlet'; ?>">
697697 <h5><?php $this->msg('namespaces') ?></h5>
698698 <ul <?php $this->html('userlangattributes') ?>>
699699 <?php foreach ($this->data['namespace_urls'] as $key => $link ): ?>
@@ -704,7 +704,7 @@
705705 break;
706706 case 'VARIANTS':
707707 ?>
708 -<div id="variants" class="vectorMenu<?php if ( count( $this->data['variant_urls'] ) == 0 ) echo ' emptyPortlet'; ?>">
 708+<div id="p-variants" class="vectorMenu<?php if ( count( $this->data['variant_urls'] ) == 0 ) echo ' emptyPortlet'; ?>">
709709 <h5><span><?php $this->msg('variants') ?></span><a href="#"></a></h5>
710710 <div class="menu">
711711 <ul <?php $this->html('userlangattributes') ?>>
@@ -718,7 +718,7 @@
719719 break;
720720 case 'VIEWS':
721721 ?>
722 -<div id="views" class="vectorTabs<?php if ( count( $this->data['view_urls'] ) == 0 ) echo ' emptyPortlet'; ?>">
 722+<div id="p-views" class="vectorTabs<?php if ( count( $this->data['view_urls'] ) == 0 ) echo ' emptyPortlet'; ?>">
723723 <h5><?php $this->msg('views') ?></h5>
724724 <ul <?php $this->html('userlangattributes') ?>>
725725 <?php foreach ($this->data['view_urls'] as $key => $link ): ?>

Status & tagging log