r56039 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56038‎ | r56039 | r56040 >
Date:15:29, 8 September 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* Update messages in JavaScript
* tweak 'mwe-error_load_lib'
* add a missing message to mwEmbed.i18n.php
Modified paths:
  • /trunk/phase3/js2/mwEmbed/libAddMedia/remoteSearchDriver.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/mv_embed.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/php/languages/mwEmbed.i18n.php (modified) (history)

Diff [purge]

Index: trunk/phase3/js2/mwEmbed/libAddMedia/remoteSearchDriver.js
@@ -30,7 +30,7 @@
3131 "mwe-cc_sa_title" : "Share Alike",
3232 "mwe-cc_pd_title" : "Public Domain",
3333 "mwe-unknown_license" : "Unknown license",
34 - "mwe-no_import_by_url" : "This user or wiki <b>can not<\/b> import assets from remote URLs.<\/p><p>Do you need to login?<\/p><p>If permissions are set, you may have to enable $wgAllowCopyUploads (<a href=\"http:\/\/www.mediawiki.org\/wiki\/Manual:$wgAllowCopyUploads\">more information<\/a>).<\/p>",
 34+ "mwe-no_import_by_url" : "This user or wiki <b>can not<\/b> import assets from remote URLs.<p>Do you need to login?<\/p><p>If permissions are set, you may have to enable <a href=\"http:\/\/www.mediawiki.org\/wiki\/Manual:$wgAllowCopyUploads\">$wgAllowCopyUploads<\/a>.<\/p>",
3535 "mwe-results_from" : "Results from <a href=\"$1\" target=\"_new\" >$2<\/a>",
3636 "mwe-missing_desc_see_source" : "This asset is missing a description. Please see the [$1 orginal source] and help describe it.",
3737 "rsd_config_error" : "Add media wizard configuration error: $1",
Index: trunk/phase3/js2/mwEmbed/php/languages/mwEmbed.i18n.php
@@ -102,7 +102,7 @@
103103 'mwe-size-megabytes' => '$1 MB',
104104 'mwe-size-kilobytes' => '$1 K',
105105 'mwe-size-bytes' => '$1 B',
106 - 'mwe-error_load_lib' => 'Error:: Javascript $1 was not retrievable OR does not define $2',
 106+ 'mwe-error_load_lib' => 'Error: JavaScript $1 was not retrievable or does not define $2',
107107
108108 /*
109109 * js file: /libAddMedia/mvFirefogg.js
@@ -272,6 +272,7 @@
273273 'mwe-playerselect' => 'Players',
274274 'mwe-read_before_embed' => 'Please read the <a href="http://mediawiki.org/wiki/Security_Notes_on_Remote_Embedding" target="_new">security notes on remote embedding</a> before acually embeding!',
275275 'mwe-embed_site_or_blog' => 'Embed on your site or blog',
 276+ 'mwe_related_videos' => 'Related videos',
276277 );
277278
278279 /** Message documentation (Message documentation)
Index: trunk/phase3/js2/mwEmbed/mv_embed.js
@@ -118,7 +118,7 @@
119119 "mwe-size-megabytes" : "$1 MB",
120120 "mwe-size-kilobytes" : "$1 K",
121121 "mwe-size-bytes" : "$1 B",
122 - "mwe-error_load_lib" : "Error:: Javascript $1 was not retrievable OR does not define $2"
 122+ "mwe-error_load_lib" : "Error: JavaScript $1 was not retrievable or does not define $2"
123123 });
124124
125125 /**
Index: trunk/phase3/js2/mwEmbed/libEmbedVideo/embedVideo.js
@@ -6,7 +6,7 @@
77 "mwe-loading_plugin" : "loading plugin <blink>...<\/blink>",
88 "mwe-select_playback" : "Set playback preference",
99 "mwe-link_back" : "Link back",
10 - "mwe-error_load_lib" : "Error: mv_embed was unable to load required JavaScript libraries.\nInsert script via DOM has failed. Please try reloading this page.",
 10+ "mwe-error_load_lib" : "Error: JavaScript $1 was not retrievable or does not define $2",
1111 "mwe-error_swap_vid" : "Error: mv_embed was unable to swap the video tag for the mv_embed interface",
1212 "mwe-add_to_end_of_sequence" : "Add to end of sequence",
1313 "mwe-missing_video_stream" : "The video file for this stream is missing",
@@ -38,8 +38,8 @@
3939 "mwe-ogg-player-videoElement" : "Native Ogg video support",
4040 "mwe-ogg-player-vlc-activex" : "VLC ActiveX",
4141 "mwe-ogg-player-oggPlugin" : "Generic Ogg plugin",
42 - "mwe-ogg-player-quicktime-mozilla" : "Quicktime plugin",
43 - "mwe-ogg-player-quicktime-activex" : "Quicktime ActiveX",
 42+ "mwe-ogg-player-quicktime-mozilla" : "QuickTime plugin",
 43+ "mwe-ogg-player-quicktime-activex" : "QuickTime ActiveX",
4444 "mwe-ogg-player-cortado" : "Java Cortado",
4545 "mwe-ogg-player-flowplayer" : "Flowplayer",
4646 "mwe-ogg-player-selected" : "(selected)",
@@ -48,9 +48,9 @@
4949 "mwe-for_best_experience" : "For a better video playback experience we recommend:<br \/><b><a href=\"http:\/\/www.mozilla.com\/en-US\/firefox\/upgrade.html?from=mwEmbed\">Firefox 3.5<\/a>.<\/b>",
5050 "mwe-do_not_warn_again" : "Dismiss for now.",
5151 "mwe-playerselect" : "Players",
52 - "mwe-read_before_embed" : "Please <a href=\"http:\/\/mediawiki.org\/wiki\/Security_Notes_on_Remote_Embedding\" target=\"_new\">Read This<\/a> before embeding!",
53 - "mwe-embed_site_or_blog" : "Embed on your site or blog",
54 - "mwe_related_videos" : "Related Videos"
 52+ "mwe-read_before_embed" : "Please read the <a href=\"http:\/\/mediawiki.org\/wiki\/Security_Notes_on_Remote_Embedding\" target=\"_new\">security notes on remote embedding<\/a> before acually embeding!",
 53+ "mwe-embed_site_or_blog" : "Embed on your site or blog",
 54+ "mwe_related_videos" : "Related videos"
5555 });
5656
5757 //set the globals:

Status & tagging log