r56037 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56036‎ | r56037 | r56038 >
Date:15:21, 8 September 2009
Author:midom
Status:ok
Tags:
Comment:
Fix use of parser-cache-saved-timestamp, apparently the code was all there, hidden behind a catch-all branch :-)
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1896,6 +1896,7 @@
18971897
18981898 $dbw = wfGetDB( DB_MASTER );
18991899 $now = wfTimestampNow();
 1900+ $this->mTimestamp=$now;
19001901
19011902 if( $flags & EDIT_UPDATE ) {
19021903 # Update article, but only if changed.
Index: trunk/phase3/includes/Skin.php
@@ -1509,7 +1509,7 @@
15101510
15111511 function lastModified() {
15121512 global $wgLang, $wgArticle;
1513 - if( $this->mRevisionId ) {
 1513+ if( $this->mRevisionId && $this->mRevisionId != $wgArticle->getLatest()) {
15141514 $timestamp = Revision::getTimestampFromId( $wgArticle->getTitle(), $this->mRevisionId );
15151515 } else {
15161516 $timestamp = $wgArticle->getTimestamp();

Status & tagging log