r55987 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55986‎ | r55987 | r55988 >
Date:18:53, 7 September 2009
Author:raymond
Status:ok
Tags:
Comment:
Follow-up r50177: Fix a PHP notice due to typo in arrayname, message key missed too.
Notice: Undefined property: ContribsPager::$message in F:\xampp\htdocs\wiki2\includes\specials\SpecialContributions.php on line 646
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -447,7 +447,7 @@
448448
449449 function __construct( $target, $namespace = false, $year = false, $month = false, $tagFilter = false ) {
450450 parent::__construct();
451 - foreach( explode( ' ', 'uctop diff newarticle rollbacklink diff hist' ) as $msg ) {
 451+ foreach( explode( ' ', 'uctop diff newarticle rollbacklink diff hist rev-delundel' ) as $msg ) {
452452 $this->messages[$msg] = wfMsgExt( $msg, array( 'escape') );
453453 }
454454 $this->target = $target;
@@ -638,12 +638,12 @@
639639 } else {
640640 $mflag = '';
641641 }
642 -
 642+
643643 if( $wgUser->isAllowed( 'deleterevision' ) ) {
644644 // If revision was hidden from sysops
645645 if( !$rev->userCan( Revision::DELETED_RESTRICTED ) ) {
646646 $del = Xml::tags( 'span', array( 'class'=>'mw-revdelundel-link' ),
647 - '(' . $this->message['rev-delundel'] . ')' ) . ' ';
 647+ '(' . $this->messages['rev-delundel'] . ')' ) . ' ';
648648 // Otherwise, show the link...
649649 } else {
650650 $query = array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50177(bug 18666) Add show/hide to contribsaaron13:32, 4 May 2009

Status & tagging log