r55982 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55981‎ | r55982 | r55983 >
Date:17:49, 7 September 2009
Author:churchofemacs
Status:ok
Tags:
Comment:
Minor fixes to r55918 - documentation and variable names
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -239,14 +239,15 @@
240240
241241 /**
242242 * Show a note if the user is blocked and display the last block log entry.
243 - * @param Title $nt Title object for the target
 243+ * @param Title $title Title object for the target
 244+ * @param $userId ID of the user
244245 */
245 - protected function showBlock( $nt, $id ) {
 246+ protected function showBlock( $title, $userId ) {
246247 global $wgUser, $wgOut;
247 - if ( !User::newFromID( $id )->isBlocked() )
 248+ if ( !User::newFromID( $userId )->isBlocked() )
248249 return; # User is not blocked, nothing to do here
249250 $loglist = new LogEventsList( $wgUser->getSkin(), $wgOut );
250 - $pager = new LogPager( $loglist, 'block', false, $nt->getPrefixedText() );
 251+ $pager = new LogPager( $loglist, 'block', false, $title->getPrefixedText() );
251252 // Check if there is something in the block log.
252253 // If this is not the case, either the user is not blocked,
253254 // or the account has been hidden via hideuser.
@@ -264,7 +265,7 @@
265266 SpecialPage::getTitleFor( 'Log', 'block' ),
266267 wfMsgHtml( 'log-fulllog' ),
267268 array(),
268 - array( 'page' => $nt->getPrefixedText() )
 269+ array( 'page' => $title->getPrefixedText() )
269270 ) );
270271 }
271272 $wgOut->addHTML( '</div>' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55918fixing r55909: checking if the user is _currently_ blocked before displaying ...churchofemacs12:04, 7 September 2009

Status & tagging log