r55862 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55861‎ | r55862 | r55863 >
Date:23:20, 5 September 2009
Author:aaron
Status:ok
Tags:
Comment:
Move checkboxes back a bit
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -364,8 +364,8 @@
365365 'action' => $this->getTitle()->getLocalUrl( array( 'action' => 'submit' ) ),
366366 'id' => 'mw-revdel-form-revisions' ) ) .
367367 Xml::fieldset( wfMsg( 'revdelete-legend' ) ) .
 368+ $this->buildCheckBoxes( $bitfields ) .
368369 Xml::openElement( 'table' ) .
369 - $this->buildCheckBoxes( $bitfields ) .
370370 "<tr>\n" .
371371 '<td class="mw-label">' .
372372 Xml::label( wfMsg( 'revdelete-log' ), 'wpRevDeleteReasonList' ) .
@@ -428,7 +428,7 @@
429429 * @return String: HTML
430430 */
431431 protected function buildCheckBoxes( $bitfields ) {
432 - $html = '';
 432+ $html = '<table>';
433433 // FIXME: all items checked for just one rev are checked, even if not set for the others
434434 foreach( $this->checks as $item ) {
435435 list( $message, $name, $field ) = $item;
@@ -436,8 +436,9 @@
437437 if( $field == Revision::DELETED_RESTRICTED )
438438 $innerHTML = "<b>$innerHTML</b>";
439439 $line = Xml::tags( 'td', array( 'class' => 'mw-input' ), $innerHTML );
440 - $html .= '<tr><td></td>' . $line . "</tr>\n";
 440+ $html .= '<tr>' . $line . "</tr>\n";
441441 }
 442+ $html .= '</table>';
442443 return $html;
443444 }
444445

Status & tagging log