r55846 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55845‎ | r55846 | r55847 >
Date:10:04, 5 September 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix LiquidThreads quoting.
TODO: Replace the icon with something that a) Fits; and b) Looks half-way decent.
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
@@ -414,6 +414,13 @@
415415 margin-left: 8px;
416416 }
417417
 418+.lqt-command-quote a {
 419+ background-image: url(icons/quote.png);
 420+ margin-left: 8px;
 421+ padding-left: 26px;
 422+ background-position: left center !important;
 423+}
 424+
418425 .lqt-command-link a {
419426 background-image: url(icons/link.png) !important;
420427 padding-left: 26px;
@@ -431,8 +438,6 @@
432439 float: left;
433440 }
434441
435 -
436 -
437442 .lqt-command {
438443 margin-top: 8px;
439444 padding: 0;
Index: trunk/extensions/LiquidThreads/lqt.js
@@ -137,7 +137,7 @@
138138 // Get the post node
139139 // Keep walking up until we hit the thread node.
140140 var thread = $j(this).closest('.lqt_thread');
141 - var post = thread.find('.lqt_post');
 141+ var post = $j(thread.find('.lqt_post')[0]);
142142
143143 var text = liquidThreads.getSelection();
144144
@@ -165,11 +165,12 @@
166166 },
167167
168168 'showQuoteButtons' : function() {
169 - var elems = $j('.lqt-thread-toolbar-rhs');
 169+ var elems = $j('.lqt-thread-toolbar-commands');
170170
171171 elems.each( function(i) {
172 - var quoteButton = $j('<span/>' );
173 - quoteButton.className = 'lqt-header-quote';
 172+ var quoteButton = $j('<li/>' );
 173+ quoteButton.addClass('lqt-command');
 174+ quoteButton.addClass('lqt-command-quote');
174175
175176 var link = $j('<a href="#"/>');
176177 link.append( wgLqtMessages['lqt-quote'] );
@@ -177,7 +178,6 @@
178179
179180 quoteButton.click( liquidThreads.doQuote );
180181
181 - $j(this).prepend( ' | ' );
182182 $j(this).prepend( quoteButton );
183183 } );
184184 },
@@ -240,7 +240,7 @@
241241 } );
242242
243243 // Update the new thread link
244 - var newThreadLink = $j('a.lqt_start_discussion');
 244+ var newThreadLink = $j('.lqt_start_discussion a');
245245
246246 if (newThreadLink) {
247247 newThreadLink.click( liquidThreads.handleNewLink );

Status & tagging log