r55799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55798‎ | r55799 | r55800 >
Date:02:40, 4 September 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Fixed a bug whereby if a recache is triggered via getSubitem(), the subitem requested will be saved into the process cache as missing.
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -275,7 +275,9 @@
276276 $this->initLanguage( $code );
277277 }
278278 // Check to see if initLanguage() loaded it for us
279 - if ( isset( $this->loadedSubitems[$code][$key][$subkey] ) ) {
 279+ if ( isset( $this->loadedItems[$code][$key] )
 280+ || isset( $this->loadedSubitems[$code][$key][$subkey] ) )
 281+ {
280282 return;
281283 }
282284 if ( isset( $this->shallowFallbacks[$code] ) ) {

Status & tagging log