r55795 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55794‎ | r55795 | r55796 >
Date:00:43, 4 September 2009
Author:tstarling
Status:ok
Tags:
Comment:
Applied patch by Juliano F. Ravasi for bug 20431: constructor for PPCustomFrame_* failed to initialise the object properly.
Modified paths:
  • /trunk/phase3/includes/parser/Preprocessor_DOM.php (modified) (history)
  • /trunk/phase3/includes/parser/Preprocessor_Hash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Preprocessor_Hash.php
@@ -1186,8 +1186,7 @@
11871187 var $numberedExpansionCache, $namedExpansionCache;
11881188
11891189 function __construct( $preprocessor, $parent = false, $numberedArgs = array(), $namedArgs = array(), $title = false ) {
1190 - $this->preprocessor = $preprocessor;
1191 - $this->parser = $preprocessor->parser;
 1190+ PPFrame_Hash::__construct( $preprocessor );
11921191 $this->parent = $parent;
11931192 $this->numberedArgs = $numberedArgs;
11941193 $this->namedArgs = $namedArgs;
@@ -1299,8 +1298,7 @@
13001299 var $args;
13011300
13021301 function __construct( $preprocessor, $args ) {
1303 - $this->preprocessor = $preprocessor;
1304 - $this->parser = $preprocessor->parser;
 1302+ PPFrame_Hash::__construct( $preprocessor );
13051303 $this->args = $args;
13061304 }
13071305
Index: trunk/phase3/includes/parser/Preprocessor_DOM.php
@@ -1239,8 +1239,7 @@
12401240 var $numberedExpansionCache, $namedExpansionCache;
12411241
12421242 function __construct( $preprocessor, $parent = false, $numberedArgs = array(), $namedArgs = array(), $title = false ) {
1243 - $this->preprocessor = $preprocessor;
1244 - $this->parser = $preprocessor->parser;
 1243+ PPFrame_DOM::__construct( $preprocessor );
12451244 $this->parent = $parent;
12461245 $this->numberedArgs = $numberedArgs;
12471246 $this->namedArgs = $namedArgs;
@@ -1352,8 +1351,7 @@
13531352 var $args;
13541353
13551354 function __construct( $preprocessor, $args ) {
1356 - $this->preprocessor = $preprocessor;
1357 - $this->parser = $preprocessor->parser;
 1355+ PPFrame_DOM::__construct( $preprocessor );
13581356 $this->args = $args;
13591357 }
13601358

Status & tagging log