r55787 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r55786‎ | r55787 | r55788 >
Date:22:24, 3 September 2009
Author:tparscal
Status:deferred
Tags:
Comment:
Created new loading spinners, one for the dialogs which needs a white background and 16x16px size, and one for the toolbar which needs a light gray background and a 24x24px size. Also changed link dialog status icons from squares to circles.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.toolbar.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/insert-link-exists.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/insert-link-invalid.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/insert-link-notexists.png (modified) (history)
  • /trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/loading.gif (added) (history)
  • /trunk/extensions/UsabilityInitiative/images/wikiEditor/loading.gif (deleted) (history)
  • /trunk/extensions/UsabilityInitiative/images/wikiEditor/toolbar/loading.gif (added) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/images/wikiEditor/loading.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/insert-link-exists.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/insert-link-notexists.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/loading.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/loading.gif
___________________________________________________________________
Name: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/images/wikiEditor/dialogs/insert-link-invalid.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/UsabilityInitiative/images/wikiEditor/toolbar/loading.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/images/wikiEditor/toolbar/loading.gif
___________________________________________________________________
Name: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
——@@ -832,7 +832,7 @@
833833 } ) )
834834 .append( $j( '<img />' ).attr( {
835835 'id': 'edittoolbar-link-int-target-status-loading',
836 - 'src': $j.wikiEditor.imgPath + 'loading.gif',
 836+ 'src': $j.wikiEditor.imgPath + 'dialogs/loading.gif',
837837 'alt': loadingMsg,
838838 'title': loadingMsg
839839 } ) )
Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.toolbar.css
——@@ -34,7 +34,7 @@
3535 }
3636 .wikiEditor-ui-toolbar .sections .loading .spinner {
3737 display: block;
38 - background-image: url(../images/wikiEditor/loading.gif);
 38+ background-image: url(../images/wikiEditor/toolbar/loading.gif);
3939 background-position: left center;
4040 background-repeat: no-repeat;
4141 padding-left: 32px;

Status & tagging log