r55779 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55778‎ | r55779 | r55780 >
Date:17:31, 3 September 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.3.4
Modified paths:
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsUtils.php (modified) (history)
  • /trunk/extensions/Maps/Maps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps.php
@@ -100,7 +100,7 @@
101101 * Initialization function for the Maps extension
102102 */
103103 function efMapsSetup() {
104 - global $wgExtensionCredits, $wgOut, $wgAutoloadClasses, $IP;
 104+ global $wgExtensionCredits, $wgOut, $wgLang, $wgAutoloadClasses, $IP;
105105 global $egMapsDefaultService, $egMapsAvailableServices, $egMapsServices, $egMapsScriptPath, $egMapsDefaultGeoService, $egMapsAvailableGeoServices, $egMapsIP;
106106
107107 efMapsValidateGoogleMapsKey();
@@ -114,7 +114,7 @@
115115 // Creation of a list of internationalized service names
116116 $services = array();
117117 foreach (array_keys($egMapsServices) as $name) $services[] = wfMsg('maps_'.$name);
118 - $services_list = implode(', ', $services);
 118+ $services_list = $wgLang->listToText($services);
119119
120120 $wgExtensionCredits['parserhook'][] = array(
121121 'path' => __FILE__,
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMapsUtils.php
@@ -117,7 +117,6 @@
118118 global $egGoogleMapsKey, $egMapsIncludePath, $egGoogleMapsOnThisPage;
119119
120120 if (empty($egGoogleMapsOnThisPage)) {
121 -
122121 $egGoogleMapsOnThisPage = 0;
123122 $output .= "<script src='http://maps.google.com/maps?file=api&v=2&key=$egGoogleMapsKey&hl={$wgLang->getCode()}' type='$wgJsMimeType'></script>
124123 <script type='$wgJsMimeType' src='$egMapsIncludePath/GoogleMaps/GoogleMapFunctions.js'></script>";

Status & tagging log