r55766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55765‎ | r55766 | r55767 >
Date:02:31, 3 September 2009
Author:aaron
Status:ok
Tags:
Comment:
(bug 20480) Double check NS before adding review links to RC
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -1573,8 +1573,10 @@
15741574
15751575 public static function addToChangeListLine( &$list, &$articlelink, &$s, &$rc, $unpatrolled, $watched ) {
15761576 global $wgUser;
1577 - if( $rc->getTitle()->getNamespace() < 0 || !isset($rc->mAttribs['fpp_rev_id']) )
1578 - return true; // reviewed pages only
 1577+ if( empty($rc->mAttribs['fpp_rev_id']) )
 1578+ return true; // page is not listed in pending edit table
 1579+ if( !FlaggedRevs::isPageReviewable($rc->getTitle()) )
 1580+ return true; // confirm that page is in reviewable namespace
15791581 wfLoadExtensionMessages( 'FlaggedRevs' );
15801582 $rlink = $list->skin->makeKnownLinkObj( $rc->getTitle(), wfMsg('revreview-reviewlink'),
15811583 'oldid='.intval($rc->mAttribs['fpp_rev_id']).'&diff=cur' );

Status & tagging log