r55762 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55761‎ | r55762 | r55763 >
Date:21:46, 2 September 2009
Author:aaron
Status:ok
Tags:
Comment:
* Fix for r55741 - selecting no revisions made PHP notices
* Some unrelated cleanups to old code
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -113,7 +113,7 @@
114114 $this->ids = explode( ',', $ids );
115115 } else {
116116 # Array input
117 - $this->ids = array_keys( $wgRequest->getArray( 'ids' ) );
 117+ $this->ids = array_keys( $wgRequest->getArray('ids',array()) );
118118 }
119119 $this->ids = array_map( 'intval', $this->ids );
120120 $this->ids = array_unique( array_filter( $this->ids ) );
@@ -1325,8 +1325,7 @@
13261326 }
13271327
13281328 public function getBits() {
1329 - /** FIXME: use accessor */
1330 - return $this->file->deleted;
 1329+ return $this->file->getVisibility();
13311330 }
13321331
13331332 public function setBits( $bits ) {
@@ -1511,7 +1510,8 @@
15121511 'target' => $this->list->title->getPrefixedText(),
15131512 'file' => $key,
15141513 'token' => $wgUser->editToken( $key )
1515 - ) );
 1514+ )
 1515+ );
15161516 }
15171517 }
15181518
@@ -1614,8 +1614,8 @@
16151615 $action = '<span class="history-deleted">' . $action . '</span>';
16161616 }
16171617 // User links
1618 - $userLink = $this->special->skin->userLink(
1619 - $this->row->log_user, User::WhoIs( $this->row->log_user ) );
 1618+ $userLink = $this->special->skin->userLink( $this->row->log_user,
 1619+ User::WhoIs( $this->row->log_user ) );
16201620 if( LogEventsList::isDeleted($this->row,LogPage::DELETED_USER) ) {
16211621 $userLink = '<span class="history-deleted">' . $userLink . '</span>';
16221622 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55741* Fixed CR r48837. Although using ids[]=x in the query string is wrong and br...tstarling01:59, 2 September 2009

Status & tagging log