r55752 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55751‎ | r55752 | r55753 >
Date:10:46, 2 September 2009
Author:jojo
Status:deferred
Tags:
Comment:
improve buttons: make them more scalable with less HTML elements
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)
  • /trunk/extensions/Collection/images/cancel-button.png (deleted) (history)
  • /trunk/extensions/Collection/images/green-button-back.png (added) (history)
  • /trunk/extensions/Collection/images/ok-button.png (deleted) (history)
  • /trunk/extensions/Collection/images/red-button-back.png (added) (history)

Diff [purge]

Index: trunk/extensions/Collection/images/cancel-button.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Collection/images/ok-button.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Collection/images/red-button-back.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/Collection/images/red-button-back.png
___________________________________________________________________
Name: svn:mime-type
11 + image/png
Index: trunk/extensions/Collection/images/green-button-back.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/Collection/images/green-button-back.png
___________________________________________________________________
Name: svn:mime-type
22 + image/png
Index: trunk/extensions/Collection/Collection.body.php
@@ -286,37 +286,25 @@
287287 <style type="text/css">
288288 .collection-button {
289289 float: left;
290 - padding: 0 10px 0 14px;
291 - height: 29px;
 290+ padding: 4px 10px;
 291+ border: 1px solid #777;
 292+ -webkit-border-radius: 8px;
 293+ -moz-border-radius: 8px;
292294 }
293295
294296 .collection-button.ok {
295 - background: url($imagepath/ok-button.png) left top no-repeat;
296 -}
297 -
298 -.collection-button.okright {
299 - background: url($imagepath/ok-button.png) right top no-repeat;
 297+ background: url($imagepath/green-button-back.png) center no-repeat;
300298 margin-right: 10px;
301 - padding: 0;
302 - width: 4px;
303299 }
304300
305301 .collection-button.cancel {
306 - background: url($imagepath/cancel-button.png) left top no-repeat;
 302+ background: url($imagepath/red-button-back.png) center no-repeat;
307303 }
308304
309 -.collection-button.cancelright {
310 - background: url($imagepath/cancel-button.png) right top no-repeat;
311 - padding: 0;
312 - width: 4px;
313 -}
314 -
315305 .collection-button a {
316 - display: block;
317306 color: #fff;
318307 font-size: 1.1em;
319308 font-weight: bold;
320 - line-height: 29px;
321309 }
322310
323311 .collection-button a:hover {
@@ -348,12 +336,6 @@
349337 wfMsg( 'coll-start_book_mode' )
350338 )
351339 )
352 - . Xml::element( 'div',
353 - array(
354 - 'class' => 'collection-button okright',
355 - ),
356 - '', false
357 - )
358340 . Xml::tags( 'div',
359341 array(
360342 'class' => 'collection-button cancel',
@@ -373,12 +355,6 @@
374356 )
375357 . Xml::element( 'div',
376358 array(
377 - 'class' => 'collection-button cancelright',
378 - ),
379 - '', false
380 - )
381 - . Xml::element( 'div',
382 - array(
383359 'style' => 'clear: both;',
384360 ),
385361 '', false

Status & tagging log