r55665 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55664‎ | r55665 | r55666 >
Date:07:40, 29 August 2009
Author:emufarmers
Status:ok
Tags:
Comment:
Add set_time_limit( 0 ) to the installer; this should cut down on cases during installation where no user gets created, and during upgrades where people don't know that they might have to run the script several times.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -460,6 +460,11 @@
461461 dieout( "The PCRE support module appears to be missing. MediaWiki requires the
462462 Perl-compatible regular expression functions." );
463463
 464+# The installer can take a while, and we really don't want it to time out
 465+wfSuppressWarnings();
 466+set_time_limit( 0 );
 467+wfRestoreWarnings();
 468+
464469 $memlimit = ini_get( "memory_limit" );
465470 if( $memlimit == -1 ) {
466471 print "<li>PHP is configured with no <tt>memory_limit</tt>.</li>\n";
Index: trunk/phase3/RELEASE-NOTES
@@ -437,6 +437,7 @@
438438 if they contain non-ASCII characters
439439 * (bug 19055) maintenance/rebuildrecentchanges.php now purges
440440 Special:Recentchanges's RSS and Atom feed cache
 441+* The installer will now try to bypass PHP's max_execution_time
441442
442443 == API changes in 1.16 ==
443444

Status & tagging log