r55642 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55641‎ | r55642 | r55643 >
Date:21:15, 27 August 2009
Author:ialex
Status:deferred
Tags:
Comment:
(bug 20425) Patch for "Piwik Integration" extension v1.5.1 - This patch fixes the problems in the special page.
Patch by Isaac Sánchez Barrera - http://bug-attachment.wikimedia.org/attachment.cgi?id=6500
Modified paths:
  • /trunk/extensions/Piwik/Piwik.php (modified) (history)
  • /trunk/extensions/Piwik/Piwik_specialpage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Piwik/Piwik_specialpage.php
@@ -29,11 +29,13 @@
3030 // checking
3131 $piwikpage = <<<PIWIK
3232 <h2>{$lastvisits}</h2>
33 - <iframe src="{$wgPiwikURL}/index.php?module=Widgetize&amp;action=iframe&amp;moduleToWidgetize=VisitsSummary&amp;actionToWidgetize=getLastVisitsGraph&amp;idSite={$wgPiwikIDSite}&amp;period=day&amp;date=previous30" marginheight="0" marginwidth="0" frameborder="0" height="150" scrolling="no" width="100%"></iframe>
 33+ <iframe src="http://{$wgPiwikURL}/index.php?module=Widgetize&amp;action=iframe&amp;columns[]=nb_visits&amp;moduleToWidgetize=VisitsSummary&amp;actionToWidgetize=getEvolutionGraph&amp;idSite={$wgPiwikIDSite}&amp;period=day&amp;date=last30&amp;disableLink=1" marginheight="0" marginwidth="0" frameborder="0" height="250" scrolling="no" width="100%"></iframe>
 34+
3435 <h2>{$countries}</h2>
35 - <iframe src="{$wgPiwikURL}/index.php?module=Widgetize&amp;action=iframe&amp;moduleToWidgetize=UserCountry&amp;actionToWidgetize=getCountry&amp;idSite={$wgPiwikIDSite}&amp;period=day&amp;date=yesterday" marginheight="0" marginwidth="0" frameborder="0" scrolling="no" height="400" width="100%"></iframe>
 36+ <iframe src="http://{$wgPiwikURL}/index.php?module=Widgetize&amp;action=iframe&amp;moduleToWidgetize=UserCountry&amp;actionToWidgetize=getCountry&amp;idSite={$wgPiwikIDSite}&amp;period=day&amp;date=yesterday&amp;disableLink=1" marginheight="0" marginwidth="0" frameborder="0" scrolling="no" height="400" width="100%"></iframe>
 37+
3638 <h2>{$browsers}</h2>
37 - <iframe src="{$wgPiwikURL}/index.php?module=Widgetize&amp;action=iframe&amp;moduleToWidgetize=UserSettings&amp;actionToWidgetize=getBrowser&amp;idSite={$wgPiwikIDSite}&amp;period=day&amp;date=yesterday" marginheight="0" marginwidth="0" frameborder="0" scrolling="no" height="400" width="100%"></iframe>
 39+ <iframe src="http://{$wgPiwikURL}/index.php?module=Widgetize&amp;action=iframe&amp;moduleToWidgetize=UserSettings&amp;actionToWidgetize=getBrowser&amp;idSite={$wgPiwikIDSite}&amp;period=day&amp;date=yesterday&amp;disableLink=1" marginheight="0" marginwidth="0" frameborder="0" scrolling="no" height="400" width="100%"></iframe>
3840
3941 PIWIK;
4042
Index: trunk/extensions/Piwik/Piwik.php
@@ -15,7 +15,7 @@
1616 $wgExtensionCredits['specialpage'][] = array(
1717 'path' => __FILE__,
1818 'name' => 'Piwik Integration',
19 - 'version' => '1.5-piwik0.4.2',
 19+ 'version' => '1.5.1-piwik0.4.3',
2020 'author' => 'Isb1009',
2121 'description' => 'Inserts Piwik script into MediaWiki pages for tracking and adds [[Special:Piwik|some stats]]. Based on Google Analytics Integration by Tim Laqua.',
2222 'descriptionmsg' => 'piwik-desc',

Status & tagging log