r55625 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r55624‎ | r55625 | r55626 >
Date:15:01, 27 August 2009
Author:catrope
Status:ok
Tags:
Comment:
wmf-deployment: Merge r55624 (fix long-running queries in ApiQueryBacklinks)
Modified paths:
  • /branches/wmf-deployment/includes/api/ApiQueryBacklinks.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/includes/api/ApiQueryBacklinks.php
——@@ -103,7 +103,7 @@
104104 * LIMIT 11 ORDER BY pl_from
105105 */
106106 $db = $this->getDB();
107 - $this->addTables(array('page', $this->bl_table));
 107+ $this->addTables(array($this->bl_table, 'page'));
108108 $this->addWhere("{$this->bl_from}=page_id");
109109 if(is_null($resultPageSet))
110110 $this->addFields(array('page_id', 'page_title', 'page_namespace'));
——@@ -122,6 +122,7 @@
123123 $this->addWhereFld('page_is_redirect', 0);
124124 $this->addOption('LIMIT', $this->params['limit'] + 1);
125125 $this->addOption('ORDER BY', $this->bl_from);
 126+ $this->addOption('STRAIGHT_JOIN');
126127 }
127128
128129 private function prepareSecondQuery($resultPageSet = null) {
Property changes on: branches/wmf-deployment/includes/api/ApiQueryBacklinks.php
___________________________________________________________________
Name: svn:mergeinfo
129130 + /branches/REL1_15/phase3/includes/api/ApiQueryBacklinks.php:51646
/trunk/phase3/includes/api/ApiQueryBacklinks.php:52290,52402,52404,52718,52737,52759,52776,52791,52800,52808,52812-52813,52815-52819,52822,52846,52850,52852-52853,52855-52857,52859,52924,52986,53128-53129,53190,53197,53199,53203-53204,53210-53211,53247,53249,53252,53267,53270,53293,53305,53344,53369,53427,53502-53504,53506,53777,54384,54494,54592,54599-54602,54604,54613,54764,54793,54806,55178,55624

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55624API: Do a STRAIGHT_JOIN in ApiQueryBacklinks's first query to counter a MySQL...catrope14:58, 27 August 2009

Status & tagging log