r55620 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55619‎ | r55620 | r55621 >
Date:14:30, 27 August 2009
Author:dale
Status:ok
Tags:
Comment:
quick fix for r55604 broken chunk upload class abstraction
Modified paths:
  • /trunk/phase3/includes/upload/UploadFromChunks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadFromChunks.php
@@ -2,9 +2,9 @@
33 /**
44 * @file
55 * @ingroup upload
6 - *
 6+ *
77 * @author Michael Dale
8 - *
 8+ *
99 * first destination checks are made (if ignorewarnings is not checked) errors / warning is returned.
1010 *
1111 * we return the uploadUrl
@@ -22,8 +22,10 @@
2323 const INIT = 1;
2424 const CHUNK = 2;
2525 const DONE = 3;
26 -
27 - function initializeFromParams( $param, &$request ) {
 26+ public function initializeFromRequest( &$request ){
 27+ //should merge initializeFromParams (but just needs to be working atm)
 28+ }
 29+ public function initializeFromParams( $param, &$request ) {
2830 $this->initFromSessionKey( $param['chunksessionkey'], $request );
2931 // set the chunk mode:
3032 if( !$this->mSessionKey && !$param['done'] ){
@@ -46,7 +48,6 @@
4749
4850 return $this->status;
4951 }
50 -
5152 static function isValidRequest( $request ) {
5253 $sessionData = $request->getSessionData( 'wsUploadData' );
5354 if( !self::isValidSessionKey(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55604* Code style & commenting on upload functions....btongminh17:05, 26 August 2009

Status & tagging log