r55614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55613‎ | r55614 | r55615 >
Date:20:48, 26 August 2009
Author:jojo
Status:deferred
Tags:
Comment:
fix URL construction by using shorter code

Thanks to CoR for the report & fix!
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -832,14 +832,14 @@
833833 return;
834834 }
835835
836 - $redirect = SkinTemplate::makeSpecialUrlSubpage( 'Book', 'rendering/' );
837836 $query = 'return_to=' . urlencode( $referrer->getPrefixedText() )
838837 . '&collection_id=' . urlencode( $response['collection_id'] )
839838 . '&writer=' . urlencode( $response['writer'] );
840839 if ( isset( $response['is_cached'] ) && $response['is_cached'] ) {
841840 $query .= '&is_cached=1';
842841 }
843 - $wgOut->redirect( wfAppendQuery( $redirect, $query ) );
 842+ $redirect = SkinTemplate::makeSpecialUrlSubpage( 'Book', 'rendering/', $query );
 843+ $wgOut->redirect( $redirect );
844844 }
845845
846846 function forceRenderCollection() {

Status & tagging log