r55588 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55587‎ | r55588 | r55589 >
Date:22:27, 25 August 2009
Author:demon
Status:ok
Tags:
Comment:
Revert r53841 (Favicon, apple-touch-icon links matching the defaults should not be sent). Doesn't actually work upon further testing
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -156,7 +156,7 @@
157157 $wgUploadDirectory = false; ///< defaults to "{$IP}/images"
158158 $wgHashedUploadDirectory = true;
159159 $wgLogo = false; ///< defaults to "{$wgStylePath}/common/images/wiki.png"
160 -$wgFavicon = false; ///< will be treated as '/favicon.ico' anyway by user agents
 160+$wgFavicon = '/favicon.ico';
161161 $wgAppleTouchIcon = false; ///< This one'll actually default to off. For iPhone and iPod Touch web app bookmarks
162162 $wgMathPath = false; ///< defaults to "{$wgUploadPath}/math"
163163 $wgMathDirectory = false; ///< defaults to "{$wgUploadDirectory}/math"
Index: trunk/phase3/includes/Skin.php
@@ -178,17 +178,15 @@
179179
180180 wfProfileIn( __METHOD__ );
181181
182 - # Add favicons and Apple touch icons, if they're not the defaults
183 - #
184182 # Generally the order of the favicon and apple-touch-icon links
185183 # should not matter, but Konqueror (3.5.9 at least) incorrectly
186184 # uses whichever one appears later in the HTML source. Make sure
187185 # apple-touch-icon is specified first to avoid this.
188 - if( false !== $wgAppleTouchIcon && wfExpandUrl('/apple-touch-icon.png') != wfExpandUrl($wgAppleTouchIcon) ) {
 186+ if( false !== $wgAppleTouchIcon ) {
189187 $out->addLink( array( 'rel' => 'apple-touch-icon', 'href' => $wgAppleTouchIcon ) );
190188 }
191189
192 - if( false !== $wgFavicon && wfExpandUrl('/favicon.ico') != wfExpandUrl($wgFavicon) ) {
 190+ if( false !== $wgFavicon ) {
193191 $out->addLink( array( 'rel' => 'shortcut icon', 'href' => $wgFavicon ) );
194192 }
195193
Index: trunk/phase3/RELEASE-NOTES
@@ -371,8 +371,6 @@
372372 * (bugs 18407, 18409) Special:Upload is now listed on Special:Specialpages only
373373 if uploads are enabled and the user can access it
374374 * (bug 17988) Spaces before [[Category:]] links are no longer ignored
375 -* (bug 19392) Favicon, apple-touch-icon links matching the defaults are no
376 - longer sent
377375 * (bug 19957) All known-failing tests now marked disabled; added --run-disabled
378376 option to parser test suite to run disabled tests if desired.
379377 * (bug 16311) Make recent change flags (n/m/b) <abbr>s instead of <span>s

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53841(bug 19392) Favicon, apple-touch-icon links matching the defaults should not ...demon23:42, 27 July 2009

Status & tagging log