r55556 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55555‎ | r55556 | r55557 >
Date:17:31, 24 August 2009
Author:dantman
Status:reverted
Tags:
Comment:
Missed two `new`s when refactoring new Array() to []
Modified paths:
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -671,8 +671,8 @@
672672
673673 var reverse = (span.getAttribute("sortdir") == 'down');
674674
675 - var newRows = new [];
676 - var staticRows = new [];
 675+ var newRows = [];
 676+ var staticRows = [];
677677 for (var j = rowStart; j < table.rows.length; j++) {
678678 var row = table.rows[j];
679679 if((" "+row.className+" ").indexOf(" unsortable ") < 0) {

Status & tagging log