r55553 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55552‎ | r55553 | r55554 >
Date:15:08, 24 August 2009
Author:ialex
Status:ok
Tags:
Comment:
disabled ParseKit on PHP 5.3+, it's broken and throws "Cannot redeclare class/function" in about evry file
Modified paths:
  • /trunk/phase3/maintenance/syntaxChecker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/syntaxChecker.php
@@ -42,9 +42,12 @@
4343 $this->buildFileList();
4444 $this->output( "done.\n" );
4545
 46+ // ParseKit is broken on PHP 5.3+, disabled until this is fixed
 47+ $useParseKit = function_exists( 'parsekit_compile_file' ) && version_compare( PHP_VERSION, '5.3', '<' );
 48+
4649 $this->output( "Checking syntax (this can take a really long time)...\n\n" );
4750 foreach( $this->mFiles as $f ) {
48 - if( function_exists( 'parsekit_compile_file' ) ) {
 51+ if( $useParseKit ) {
4952 $this->checkFileWithParsekit( $f );
5053 } else {
5154 $this->checkFileWithCli( $f );

Status & tagging log