r55535 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r55534‎ | r55535 | r55536 >
Date:20:19, 23 August 2009
Author:ialex
Status:deferred (Comments)
Tags:
Comment:
* (bug 20365) Page name with with c/g/h/j/s/u + x are now correctly handled in Special:MovePage with Esperanto as content language
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMovepage.php
——@@ -17,8 +17,8 @@
1818 }
1919
2020 $target = isset( $par ) ? $par : $wgRequest->getVal( 'target' );
21 - $oldTitleText = $wgRequest->getText( 'wpOldTitle', $target );
22 - $newTitleText = $wgRequest->getText( 'wpNewTitle' );
 21+ $oldTitleText = $wgRequest->getVal( 'wpOldTitle', $target );
 22+ $newTitleText = $wgRequest->getVal( 'wpNewTitle' );
2323
2424 $oldTitle = Title::newFromText( $oldTitleText );
2525 $newTitle = Title::newFromText( $newTitleText );
Index: trunk/phase3/RELEASE-NOTES
——@@ -425,8 +425,9 @@
426426 enabled
427427 * (bug 19857) maintenance/deleteRevision.php on last revision no longer breaks
428428 target page
 429+* (bug 20365) Page name with with c/g/h/j/s/u + x are now correctly handled in
 430+ Special:MovePage with Esperanto as content language
429431
430 -
431432 == API changes in 1.16 ==
432433
433434 * Added uiprop=changeablegroups to meta=userinfo

Follow-up revisions

RevisionCommit summaryAuthorDate
r56188Fix for r55535, per Brion's comment: convert x-coded strings in the target in...ialex17:17, 11 September 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   18:42, 10 September 2009

This no longer converts x-coded strings in the move target box. :(

That should still be using getText() to do input conversion, but should also pre-fill the input box with the output-encoded name as is done for the page edit box.

#Comment by IAlex (talk | contribs)   17:18, 11 September 2009

Done in r56188.

Status & tagging log