r5551 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r5550‎ | r5551 | r5552 >
Date:17:59, 26 September 2004
Author:wmahan
Status:old
Tags:
Comment:
Fix problem with RFC magic links, as noted at bug 479
Modified paths:
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -658,11 +658,11 @@
659659 $text = $wgDateFormatter->reformat( $this->mOptions->getDateFormat(), $text );
660660 }
661661 $text = $this->doAllQuotes( $text );
662 - $text = $this->doMagicLinks( $text );
663662 $text = $this->replaceInternalLinks ( $text );
664663 # Another call to replace links and images inside captions of images
665664 $text = $this->replaceInternalLinks ( $text );
666665 $text = $this->replaceExternalLinks( $text );
 666+ $text = $this->doMagicLinks( $text );
667667 $text = $this->doTableStuff( $text );
668668 $text = $this->formatHeadings( $text, $isMain );
669669 $sk =& $this->mOptions->getSkin();
@@ -1550,12 +1550,16 @@
15511551 * @access private
15521552 */
15531553 function initialiseVariables() {
 1554+ $fname = 'Parser::initialiseVaraibles';
 1555+ wfProfileIn( $fname );
15541556 global $wgVariableIDs;
15551557 $this->mVariables = array();
15561558 foreach ( $wgVariableIDs as $id ) {
15571559 $mw =& MagicWord::get( $id );
15581560 $mw->addToArray( $this->mVariables, $this->getVariableValue( $id ) );
15591561 }
 1562+ $fname = 'Parser::initialiseVaraibles';
 1563+ wfProfileOut( $fname );
15601564 }
15611565
15621566 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r9617* Marking the two RFC testcases as being parsertests for bug 479avar12:56, 24 June 2005
r17481Fix parserTests regression introduced in r17479....nickj06:03, 8 November 2006

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r5327bug 479 : parsing [[RFC 1234]] as internal linkhashar15:54, 20 September 2004
r5335Fix bug 479 : parsing [[RFC 1234]] as internal link...hashar21:41, 20 September 2004

Status & tagging log