r55507 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55506‎ | r55507 | r55508 >
Date:21:53, 22 August 2009
Author:brion
Status:ok
Tags:
Comment:
Change r52690 per suggestions on CodeReview: rearrange from boolean OR mysteriously changed to binary OR to a nice plain if statement.
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -510,8 +510,9 @@
511511 $data = $this->readPHPFile( $fileName, 'extension' );
512512 $used = false;
513513 foreach ( $data as $key => $item ) {
514 - $used = $used |
515 - $this->mergeExtensionItem( $codeSequence, $key, $allData[$key], $item );
 514+ if( $this->mergeExtensionItem( $codeSequence, $key, $allData[$key], $item ) ) {
 515+ $used = true;
 516+ }
516517 }
517518 if ( $used ) {
518519 $deps[] = new FileDependency( $fileName );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52690Replace || with |, so messages get merged regardless of $used valuevasilievvv12:59, 2 July 2009

Status & tagging log