r55493 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55492‎ | r55493 | r55494 >
Date:19:42, 22 August 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* change trim() for $postFile to ltrim(). Want the trailing newline
* update comments
Modified paths:
  • /trunk/phase3/js2/mwEmbed/php/maintenance/mergeJavascriptMsg.php (modified) (history)

Diff [purge]

Index: trunk/phase3/js2/mwEmbed/php/maintenance/mergeJavascriptMsg.php
@@ -27,7 +27,7 @@
2828 $mergeToJS = true;
2929
3030 if ( $mergeToPhp && $mergeToJS )
31 -die( 'please only set either $mergeToPhp or $mergeToJS' );
 31+die( 'Please only set either $mergeToPhp or $mergeToJS' );
3232
3333 if ( $mergeToPhp )
3434 print "Will merge *Javascript to PHP* in 3 seconds ";
@@ -47,7 +47,7 @@
4848 $startInx = strpos( $rawLangFile, $mwSTART_MSG_KEY ) + strlen( $mwSTART_MSG_KEY );
4949 $endInx = strpos( $rawLangFile, $mwEND_MSG_KEY ) + 1;
5050 if ( $startInx === false || $endInx === false ) {
51 - print "Could not find $mwSTART_MSG_KEY or $mwEND_MSG_KEY in mwEmbed.i18n.php \n";
 51+ print "Could not find $mwSTART_MSG_KEY or $mwEND_MSG_KEY in mwEmbed.i18n.php\n";
5252 exit();
5353 }
5454
@@ -77,7 +77,7 @@
7878 }
7979 // rebuild and output to single php file if mergeToPHP is on
8080 if ( $mergeToPhp ) {
81 - if ( file_put_contents( $mwLangFilePath, trim( $preFile ) . "\n\t" . trim( $msgSet ) . "\n" . trim( $postFile ) ) ) {
 81+ if ( file_put_contents( $mwLangFilePath, trim( $preFile ) . "\n\t" . trim( $msgSet ) . "\n" . ltrim( $postFile ) ) ) {
8282 print "updated $mwLangFilePath file\n";
8383 exit();
8484 }

Status & tagging log