r55443 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55442‎ | r55443 | r55444 >
Date:21:34, 21 August 2009
Author:simetrical
Status:ok
Tags:
Comment:
Omit useless value="" in Html::input()
Modified paths:
  • /trunk/phase3/includes/Html.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Html.php
@@ -347,7 +347,7 @@
348348 if ( $type != 'text' ) {
349349 $attribs['type'] = $type;
350350 }
351 - if ( $value !== null ) {
 351+ if ( $value !== null && $value !== '' ) {
352352 $attribs['value'] = $value;
353353 }
354354 $attribs['name'] = $name;

Status & tagging log