r55432 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55431‎ | r55432 | r55433 >
Date:20:39, 21 August 2009
Author:simetrical
Status:ok
Tags:
Comment:
Correct outdated comments
Modified paths:
  • /trunk/phase3/includes/Html.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Html.php
@@ -89,7 +89,7 @@
9090 * values. If you're hardcoding all the attributes, or there are none, you
9191 * should probably type out the string yourself.
9292 *
93 - * This is quite similar to Xml::element(), but it implements some useful
 93+ * This is quite similar to Xml::tags(), but it implements some useful
9494 * HTML-specific logic. For instance, there is no $allowShortTag
9595 * parameter: the closing tag is magically omitted if $element has an empty
9696 * content model. If $wgWellFormedXml is false, then a few bytes will be
@@ -97,10 +97,6 @@
9898 * features might be added, like allowing arrays for the values of
9999 * attributes like class= and media=.
100100 *
101 - * One notable difference to Xml::element() is that $contents is *not*
102 - * escaped. This means that Html::element() can be usefully nested, rather
103 - * than using the rather clumsy Xml::openElement() and Xml::closeElement().
104 - *
105101 * @param $element string The element's name, e.g., 'a'
106102 * @param $attribs array Associative array of attributes, e.g., array(
107103 * 'href' => 'http://www.mediawiki.org/' ). Values will be HTML-escaped.
@@ -123,7 +119,8 @@
124120 }
125121
126122 /**
127 - * Identical to rawElement(), but HTML-escapes $contents.
 123+ * Identical to rawElement(), but HTML-escapes $contents (like
 124+ * Xml::element()).
128125 */
129126 public static function element( $element, $attribs = array(), $contents = '' ) {
130127 return self::rawElement( $element, $attribs, strtr( $contents, array(

Status & tagging log