r55426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55425‎ | r55426 | r55427 >
Date:19:53, 21 August 2009
Author:nimishg
Status:deferred
Tags:
Comment:
click tracking enabled for toolbar
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
@@ -199,7 +199,8 @@
200200 */
201201 doAction : function( context, action, source ) {
202202 // Verify that this has been called from a source that's within the toolbar
203 - if ( source.closest( '.wikiEditor-ui-toolbar' ).size() ) {
 203+ // 'trackAction' defined in click tracking
 204+ if ($.trackAction != undefined && source.closest( '.wikiEditor-ui-toolbar' ).size() ) {
204205 // Build a unique id for this action by tracking the parent rel attributes up to the toolbar level
205206 var rels = [];
206207 var step = source;
@@ -217,7 +218,7 @@
218219 }
219220 rels.reverse();
220221 var id = rels.join( '.' );
221 - // PERFORM CLICK TRACKING HERE!
 222+ $.trackAction(id);
222223 }
223224 switch ( action.type ) {
224225 case 'replace':

Status & tagging log