r55417 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55416‎ | r55417 | r55418 >
Date:17:04, 21 August 2009
Author:greg
Status:deferred
Tags:
Comment:
Use databases concept of a timestamp, not MW's
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.db.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNotice.db.php
@@ -33,7 +33,7 @@
3434 if ( $preferred )
3535 $conds[] = "not_preferred = 1";
3636 if ( !$date )
37 - $date = wfTimestamp( TS_MW );
 37+ $date = $dbr->timestamp();
3838
3939 $conds[] = ( $date ) ? "not_start <= ". $dbr->addQuotes( $date ) : "not_start <= " . $dbr->addQuotes( $dbr->timestamp( $date ) );
4040 $conds[] = ( $date ) ? "not_end >= " . $dbr->addQuotes( $date ) : "not_end >= " . $dbr->addQuotes( $dbr->timestamp( $date ) );

Status & tagging log