r55391 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55390‎ | r55391 | r55392 >
Date:19:42, 20 August 2009
Author:robin
Status:deferred
Tags:
Comment:
- update RandomByTest because of r55188
- add randombytest-nopages message
Modified paths:
  • /trunk/extensions/WikimediaIncubator/SpecialRandomByTest.php (modified) (history)
  • /trunk/extensions/WikimediaIncubator/WikimediaIncubator.i18n.php (modified) (history)
  • /trunk/extensions/WikimediaIncubator/WikimediaIncubator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaIncubator/WikimediaIncubator.i18n.php
@@ -26,6 +26,7 @@
2727 'wminc-warning-suggest-move' => 'You can [{{fullurl:Special:MovePage/$3|wpNewTitle=$2}} move this page to $1].',
2828 'right-viewuserlang' => 'View [[Special:ViewUserLang|user language and test wiki]]',
2929 'randombytest' => 'Random page by test wiki',
 30+ 'randombytest-nopages' => 'There are no pages in your test wiki, in the namespace: $1.',
3031 );
3132
3233 /** Message documentation (Message documentation)
Index: trunk/extensions/WikimediaIncubator/WikimediaIncubator.php
@@ -10,7 +10,7 @@
1111 'path' => __FILE__,
1212 'name' => 'Wikimedia Incubator',
1313 'author' => 'SPQRobin',
14 - 'version' => '2.3.2',
 14+ 'version' => '2.3.3',
1515 'url' => 'http://www.mediawiki.org/wiki/Extension:WikimediaIncubator',
1616 'description' => 'Test wiki features for Wikimedia Incubator',
1717 'descriptionmsg' => 'wminc-desc',
Index: trunk/extensions/WikimediaIncubator/SpecialRandomByTest.php
@@ -7,15 +7,12 @@
88 class SpecialRandomByTest extends RandomPage
99 {
1010 public function __construct() {
11 - parent::__construct( 'RandomByTest' );
12 - }
13 -
14 - public function addExtraSQL() {
1511 global $wgUser, $wmincPref;
1612 if(IncubatorTest::isNormalPrefix()) {
17 - return 'page_title like "W'.$wgUser->getOption($wmincPref . '-project').'/'.$wgUser->getOption($wmincPref . '-code').'/%%"';
 13+ $this->extra[] = 'page_title like "W'.$wgUser->getOption($wmincPref . '-project').'/'.$wgUser->getOption($wmincPref . '-code').'/%%"';
1814 } elseif($wgUser->getOption($wmincPref . '-project') == 'inc') {
19 - return 'page_title not like "W_/%%" OR "W_/%%/%%"';
 15+ $this->extra[] = 'page_title not like "W_/%%" OR "W_/%%/%%"';
2016 }
 17+ parent::__construct( 'RandomByTest' );
2118 }
2219 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55188Re-implement r54638 in a higher-level way. Allows extensions to modify select...mrzman15:23, 17 August 2009

Status & tagging log