r55370 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55369‎ | r55370 | r55371 >
Date:10:29, 20 August 2009
Author:dale
Status:deferred
Tags:
Comment:
* slightly better sequencer css layout.
* now to fix the mismatched selectors *****I hate kskin right now****
Modified paths:
  • /trunk/phase3/js2/mwEmbed/libAddMedia/simpleUploadForm.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libSequencer/mvPlayList.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libSequencer/mvSequencer.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/skins/ctrlBuilder.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/skins/mvpcf/styles.css (modified) (history)

Diff [purge]

Index: trunk/phase3/js2/mwEmbed/libAddMedia/simpleUploadForm.js
@@ -64,7 +64,8 @@
6565 '<textarea cols="30" rows="3" name="wpUploadDescription" tabindex="3"/><br>'+
6666
6767 '<div id="wpDestFile-warning"></div>' +
68 -
 68+ '<div style="clear:both;"></div>' +
 69+
6970 gM('select_ownwork') + '<br>' +
7071 '<input type="checkbox" id="wpLicence" name="wpLicence" value="cc-by-sa">' + gM('licence_cc-by-sa') + '<br>' +
7172
@@ -90,16 +91,16 @@
9192 opt.ondone_cb = false;
9293
9394 //set up the binding per the config
94 - if( opt.enable_fogg ){
 95+ if( opt.enable_fogg ){
9596 $j("#suf-upload [name='wpUploadFile']").firefogg({
9697 //an api url (we won't submit directly to action of the form)
9798 'api_url' : opt.api_target,
9899 'form_rewrite': true,
99100 'target_edit_from' : '#suf-upload',
100101 'new_source_cb' : function( orgFilename, oggName ){
101 - $j("#suf-upload [name='wpDestFile']").val( oggName ).doDestCheck({
102 - warn_target: "#wpDestFile-warning"
103 - });
 102+ $j("#suf-upload [name='wpDestFile']").val( oggName ).doDestCheck({
 103+ warn_target: "#wpDestFile-warning"
 104+ });
104105 },
105106 'done_upload_cb' : opt.ondone_cb
106107 });
Index: trunk/phase3/js2/mwEmbed/libSequencer/mvPlayList.js
@@ -425,7 +425,7 @@
426426 //append title & controler:
427427 $j('#dc_'+_this.id).append(
428428 '<div style="font-size:13px;border:solid thin;width:'+this.width+'px;" id="ptitle_'+this.id+'"></div>' +
429 - '<div class="videoPlayer" style="position:absolute;top:'+(_this.height+_this.pl_layout.title_bar_height+4)+'px">' +
 429+ '<div class="videoPlayer" style="z-index:-1;position:absolute;top:'+(_this.height+_this.pl_layout.title_bar_height+4)+'px">' +
430430 //'<div id="mv_embedded_controls_'+_this.id+'" class="ui-widget ui-corner-bottom ui-state-default controls" '+
431431 '<div class="k-control-bar ui-widget-header ui-helper-clearfix" ' +
432432 'style="width:' + _this.width + 'px" >' +
Index: trunk/phase3/js2/mwEmbed/libSequencer/mvSequencer.js
@@ -1431,7 +1431,7 @@
14321432 $j(this.target_sequence_container).append('<div id="'+ this.timeline_id +'_pl_control"'+
14331433 ' style="position:absolute;top:' + (this.plObj.height) +'px;'+
14341434 'right:1px;width:'+this.plObj.width+'px;height:'+this.plObj.org_control_height+'" '+
1435 - 'class="videoPlayer"><div class="ui-widget ui-corner-bottom ui-state-default controls">'+
 1435+ 'class="k-player"><div class="ui-widget ui-corner-bottom ui-state-default k-control-bar">'+
14361436 this.plObj.getControlsHTML() +
14371437 '</div>'+
14381438 '</div>');
Index: trunk/phase3/js2/mwEmbed/skins/ctrlBuilder.js
@@ -405,9 +405,11 @@
406406 'closed_captions':{
407407 'w':24,
408408 'o':function(){
409 - return '<div title="' + gM('closed_captions') + '" id="timed_text_' + ctrlBuilder.id +'" ' +
 409+ return '<button class="ui-state-default ui-corner-all k-close_captions" title="' + gM('closed_captions') + '">' +
 410+ '<span class="ui-icon ui-icon-comment"></span></button>'
 411+ /*return '<div title="' + gM('closed_captions') + '" id="timed_text_' + ctrlBuilder.id +'" ' +
410412 'class="ui-state-default ui-corner-all ui-icon_link rButton">' +
411 - '<span class="ui-icon ui-icon-comment"></span></div>';
 413+ '<span class="ui-icon ui-icon-comment"></span></div>';*/
412414 }
413415 },
414416 'fullscreen':{
Index: trunk/phase3/js2/mwEmbed/skins/mvpcf/styles.css
@@ -678,24 +678,23 @@
679679 /* jquery.ui overides */
680680
681681 .ui-icon_link {
682 - padding: .4em 1em .4em 20px;
683 - text-decoration: none;
 682+ padding: .4em 1em .4em 20px !Important;
 683+ text-decoration: none !Important;
684684 position: relative;
685685 }
686686 .ui-icon_link span.ui-icon {
687 - margin: 0 5px 0 0;
688 - position: absolute;
689 - left: 0.2em;
690 - right: auto;
691 - top: 50%;
692 - margin-top: -8px;
693 - zoom: 1;
 687+ margin: 0 5px 0 0 !Important;
 688+ position: absolute !Important;
 689+ left: 0.2em !Important;
 690+ right: auto !Important;
 691+ top: 50% !Important;
 692+ margin-top: -8px !Important;
694693 }
695694 .ui-icon_link span.ui-text {
696 - position: absolute;
697 - left: 0.2em;
698 - right: auto;
699 - margin-top: -3px;
 695+ position: absolute !Important;
 696+ left: 0.2em !Important;
 697+ right: auto;
 698+ margin-top: -3px !Important;
700699 zoom: 1;
701700 }
702701
@@ -853,12 +852,12 @@
854853 .k-control-bar .k-volume-slider a:hover.ui-slider-handle { border: solid 1px #999;}
855854 .k-control-bar .k-volume-slider .ui-slider-range { height:17px; position:absolute; background: url(images/ksprite.png) repeat-x -66px -306px; -moz-border-radius:0; -webkit-border-radius:0;}
856855
857 -.play-btn-large { width:120px; height:55px; border:none; background: url(images/ksprite.png) no-repeat 28px -433px; position:absolute; cursor:pointer;} /*.ui-state-default */
 856+.play-btn-large { width:120px; height:55px; border:none; background: url(images/ksprite.png) no-repeat 28px -433px !Important; position:absolute; cursor:pointer;} /*.ui-state-default */
858857 .play-btn-large.ui-state-hover { background: url(images/ksprite.png) no-repeat 28px -377px; }
859858
860859 .k-volume.ui-state-hover { margin-left:6px; }
861860
862 -
 861+
863862 /* move to ie css */
864863 .k-volume-slider span, span.ui-icon-play, span.ui-icon-volume-on, button.k-fullscreen { *margin-top:-1px;}
865864 span.ui-icon-volume-on { *margin-left:0 !important;}
@@ -871,6 +870,9 @@
872871 /* end debug */
873872
874873 .ui-state-default, .ui-widget-content .ui-state-default {
875 - border:none;
 874+ border: thin solid;
876875 }
 876+.k-player .ui-state-default, .ui-widget-content .ui-state-default {
 877+ border: none;
 878+}
877879 /*** end player ***/
\ No newline at end of file

Status & tagging log