r55334 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55333‎ | r55334 | r55335 >
Date:18:22, 19 August 2009
Author:brion
Status:ok
Tags:
Comment:
Cleanup for r54264 "* Don't suppress warnings while developing, wasting my time for debugging"
Remove the warning suppression entirely; if you're seeing any warnings come up here it's probably because you forgot an isset() :) Please find and fix any such items.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -366,15 +366,11 @@
367367 * Outputs the entire contents of the XHTML page
368368 */
369369 public function execute() {
370 - global $wgRequest, $wgOut, $wgContLang, $wgDevelopmentWarnings;
 370+ global $wgRequest, $wgOut, $wgContLang;
371371
372372 $this->skin = $this->data['skin'];
373373 $action = $wgRequest->getText( 'action' );
374374
375 - // Suppress warnings to prevent notices about missing indexes in
376 - // $this->data (is this really the best way to handle this?)
377 - $wgDevelopmentWarnings && wfSuppressWarnings();
378 -
379375 // Build additional attributes for navigation urls
380376 $nav = $this->skin->buildNavigationUrls();
381377 foreach ( $nav as $section => $links ) {
@@ -578,8 +574,6 @@
579575 </body>
580576 </html>
581577 <?php
582 - // We're done with abusing arrays now...
583 - $wgDevelopmentWarnings && wfRestoreWarnings();
584578 }
585579
586580 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54264* Trailing Whitespace...nikerabbit10:49, 3 August 2009

Status & tagging log