r55325 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55324‎ | r55325 | r55326 >
Date:13:05, 19 August 2009
Author:dale
Status:deferred
Tags:
Comment:
* some refactored js2/mv_embed updates (keeping sync with trunk)
Modified paths:
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_VideoPlayer.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_Settings.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/specials/MV_SpecialMediaSearch.php (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_stream.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/includes/MV_Settings.php
@@ -75,7 +75,7 @@
7676 // if we should load images from an external server:
7777 $mvExternalImages = false;
7878 // path to metavidWiki install that is serving images:
79 -$mvExternalImgServerPath = 'http://mvprime.cse.ucsc.edu/wiki/index.php';
 79+$mvExternalImgServerPath = 'http://metavid.org/w/index.php';
8080
8181 $mvWebImgLoc = $mvgScriptPath . '/stream_images';
8282 // full local path for images (if hosted locally)
Index: trunk/extensions/MetavidWiki/includes/specials/MV_SpecialMediaSearch.php
@@ -976,7 +976,7 @@
977977 $result = $dbr->select( 'page', 'page_title', array (
978978 'page_namespace' => NS_CATEGORY,
979979 '`page_title` LIKE \'%' . mysql_escape_string( $val
980 - ) . '%\' COLLATE utf8_bin' ), __METHOD__, array (
 980+ ) . '%\' COLLATE latin1_swedish_ci' ), __METHOD__, array (
981981 'LIMIT' => $result_limit
982982 ) );
983983 $match_count = $dbr->numRows( $result );
@@ -998,7 +998,7 @@
999999 $result = $dbr->select( 'categorylinks', 'cl_sortkey', array (
10001000 'cl_to' => $category,
10011001 '`cl_sortkey` LIKE \'%' . mysql_escape_string( $val
1002 - ) . '%\' COLLATE utf8_bin' ), __METHOD__, array (
 1002+ ) . '%\' COLLATE latin1_swedish_ci' ), __METHOD__, array (
10031003 'LIMIT' => $result_limit
10041004 ) );
10051005 // print 'ran: ' . $dbr->lastQuery();
@@ -1025,7 +1025,7 @@
10261026 $result = $dbr->select( 'categorylinks', 'cl_sortkey', array (
10271027 'cl_to' => 'Person',
10281028 '`cl_sortkey` LIKE \'%' . mysql_escape_string( $val
1029 - ) . '%\' COLLATE utf8_bin' ), __METHOD__, array (
 1029+ ) . '%\' COLLATE latin1_swedish_ci' ), __METHOD__, array (
10301030 'LIMIT' => $result_limit
10311031 ) );
10321032 $out = '';
@@ -1160,4 +1160,4 @@
11611161 $start_day
11621162 ), 'ed' => date( 'm/d/Y', $end_day ), 'sdays' => $sDays ), $obj_name );
11631163 }
1164 -}
 1164+}
\ No newline at end of file
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_VideoPlayer.php
@@ -57,9 +57,9 @@
5858 $coma=', ';
5959 }
6060 $o.='</span>';*/
61 - $o .= '<span class="download"><a href="javascript:$j(\'#' . htmlspecialchars( $this->embed_id ) . '\').get(0).showVideoDownload()">Download Options</a></span>';
 61+ $o .= '<span class="download"><a href="javascript:$j(\'#' . htmlspecialchars( $this->embed_id ) . '\').get(0).showDownload()">Download Options</a></span>';
6262 }
63 - $o .= '<span class="embed"><a href="javascript:$j(\'#' . htmlspecialchars( $this->embed_id ) . '\').get(0).showEmbedCode();">Embed Video</a></span>' .
 63+ $o .= '<span class="embed"><a href="javascript:$j(\'#' . htmlspecialchars( $this->embed_id ) . '\').get(0).showShare();">Embed Video</a></span>' .
6464 '</p>';
6565 // about file:
6666 $talkPage = Title::newFromText( 'Anno_en:' . strtolower( $mvTitle->wiki_title ), MV_NS_MVD_TALK );
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php
@@ -217,7 +217,7 @@
218218 $this->showIntro();
219219
220220 if ( $this->mTitle->isTalkPage() ) {
221 - $wgOut->addWikiText( wfMsg( 'talkpagetext' ) );
 221+ $wgOut->addWikiMsg( 'talkpagetext' );
222222 }
223223
224224 # Attempt submission here. This will check for edit conflicts,
Index: trunk/extensions/MetavidWiki/skins/mv_stream.js
@@ -348,7 +348,7 @@
349349 js_log('f:mv_doShowVideoDownload');
350350 //restores orginal state before showing download links:
351351 mv_stream_interface.doRestore();
352 - return $j('#embed_vid').get(0).org_showVideoDownload();
 352+ return $j('#embed_vid').get(0).org_showDownload();
353353 }*/
354354 /* the mvdObject
355355 *

Status & tagging log