r55301 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55300‎ | r55301 | r55302 >
Date:01:55, 19 August 2009
Author:demon
Status:ok
Tags:
Comment:
Followup r53884, use wfSuppressWarnings/wfRestoreWarnings instead of @
Modified paths:
  • /trunk/phase3/includes/HttpFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HttpFunctions.php
@@ -586,10 +586,12 @@
587587 $status = Status::newGood();
588588 // start the session (if necessary)
589589 if( !$wgSessionsInMemcached ){
590 - if( @session_start() === false){
 590+ wfSuppressWarnings();
 591+ if( session_start() === false ){
591592 wfDebug( __METHOD__ . ' could not start session' );
592593 exit( 0 );
593594 }
 595+ wfRestoreWarnings();
594596 }
595597 $sd =& $_SESSION['wsDownload'][ $this->upload_session_key ];
596598 // check if the user canceled the request:

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53884checking for session_id() was preventing updates (just put a @ infront to ign...dale17:38, 28 July 2009

Status & tagging log