r55260 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55259‎ | r55260 | r55261 >
Date:19:45, 18 August 2009
Author:dale
Status:ok
Tags:
Comment:
* fixed SpecialUpload page iframe uploading for js2 (forgot to commit the SpecialUpload page that had the token id attr)
* fixed random error in mvFirefogg
* updated jquery skin path
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)
  • /trunk/phase3/js2/mwEmbed/libAddMedia/mvFirefogg.js (modified) (history)
  • /trunk/phase3/js2/mwEmbed/mv_embed.js (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -39,7 +39,7 @@
4040
4141 protected function initForm() {
4242 global $wgRequest, $wgUser;
43 -
 43+
4444 if ( is_null( $this->mRequest ) ) {
4545 $request = $wgRequest;
4646 } else {
@@ -96,7 +96,7 @@
9797
9898 $this->setHeaders();
9999 $this->outputHeader();
100 -
 100+
101101 $this->initForm();
102102
103103 # Check uploading enabled
@@ -606,7 +606,7 @@
607607 $wgOut->addHTML(
608608 Xml::openElement( 'form', array( 'method' => 'post', 'action' => $titleObj->getLocalURL( 'action=submit' ),
609609 'enctype' => 'multipart/form-data', 'id' => 'uploadwarning' ) ) . "\n" .
610 - Xml::hidden('wpEditToken', $wgUser->editToken()) .
 610+ Xml::hidden('wpEditToken', $wgUser->editToken(), array("id" => 'wpEditToken')) .
611611 Xml::hidden( 'wpIgnoreWarning', '1' ) . "\n" .
612612 Xml::hidden( 'wpSourceType', 'stash' ) . "\n" .
613613 Xml::hidden( 'wpSessionKey', $this->mSessionKey ) . "\n" .
@@ -833,7 +833,7 @@
834834 $wgOut->addHTML(
835835 Xml::openElement( 'form', array( 'method' => 'post', 'action' => $titleObj->getLocalURL( 'action=submit' ),
836836 'enctype' => 'multipart/form-data', 'id' => 'mw-upload-form' ) ) .
837 - Xml::hidden('wpEditToken', $wgUser->editToken()) .
 837+ Xml::hidden('wpEditToken', $wgUser->editToken(), array('id' => 'wpEditToken')) .
838838 Xml::openElement( 'fieldset' ) .
839839 Xml::element( 'legend', null, wfMsg( 'upload' ) ) .
840840 Xml::openElement( 'table', array( 'border' => '0', 'id' => 'mw-upload-table' ) ) .
Index: trunk/phase3/js2/mwEmbed/libAddMedia/mvFirefogg.js
@@ -19,7 +19,7 @@
2020
2121 });
2222
23 -var firefogg_install_inks = {
 23+var firefogg_install_links = {
2424 'macosx': 'http://firefogg.org/macosx/Firefogg.xpi',
2525 'win32' : 'http://firefogg.org/win32/Firefogg.xpi',
2626 'linux' : 'http://firefogg.org/linux/Firefogg.xpi'
Index: trunk/phase3/js2/mwEmbed/mv_embed.js
@@ -62,7 +62,7 @@
6363 }
6464
6565 //setup the skin path:
66 -var mv_jquery_skin_path = mv_embed_path + 'jquery/jquery.ui/themes/base/';
 66+var mv_jquery_skin_path = mv_embed_path + 'jquery/jquery.ui/themes/redmond/';
6767 var mv_skin_img_path = mv_embed_path + 'skins/' + mwConfig['skin_name'] + '/images/';
6868 var mv_default_thumb_url = mv_skin_img_path + 'vid_default_thumb.jpg';
6969

Status & tagging log