r55252 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55251‎ | r55252 | r55253 >
Date:18:21, 18 August 2009
Author:brion
Status:ok
Tags:
Comment:
Merge r52762 regression fix
Modified paths:
  • /branches/wmf-deployment/includes/Preferences.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/includes/Preferences.php
@@ -354,20 +354,27 @@
355355 );
356356 }
357357
358 - $defaultPreferences['enotifwatchlistpages'] =
359 - array(
360 - 'type' => 'toggle',
361 - 'section' => 'personal/email',
362 - 'label-message' => 'tog-enotifwatchlistpages',
363 - 'disabled' => $disableEmailPrefs,
364 - );
365 - $defaultPreferences['enotifusertalkpages'] =
366 - array(
367 - 'type' => 'toggle',
368 - 'section' => 'personal/email',
369 - 'label-message' => 'tog-enotifusertalkpages',
370 - 'disabled' => $disableEmailPrefs,
371 - );
 358+ global $wgEnotifWatchlist;
 359+ if ( $wgEnotifWatchlist ) {
 360+ $defaultPreferences['enotifwatchlistpages'] =
 361+ array(
 362+ 'type' => 'toggle',
 363+ 'section' => 'personal/email',
 364+ 'label-message' => 'tog-enotifwatchlistpages',
 365+ 'disabled' => $disableEmailPrefs,
 366+ );
 367+ }
 368+ global $wgEnotifUserTalk;
 369+ if( $wgEnotifUserTalk ) {
 370+ $defaultPreferences['enotifusertalkpages'] =
 371+ array(
 372+ 'type' => 'toggle',
 373+ 'section' => 'personal/email',
 374+ 'label-message' => 'tog-enotifusertalkpages',
 375+ 'disabled' => $disableEmailPrefs,
 376+ );
 377+ }
 378+ if( $wgEnotifUserTalk || $wgEnotifWatchlist ) {
372379 $defaultPreferences['enotifminoredits'] =
373380 array(
374381 'type' => 'toggle',
@@ -375,6 +382,7 @@
376383 'label-message' => 'tog-enotifminoredits',
377384 'disabled' => $disableEmailPrefs,
378385 );
 386+ }
379387 $defaultPreferences['enotifrevealaddr'] =
380388 array(
381389 'type' => 'toggle',
Property changes on: branches/wmf-deployment/includes/Preferences.php
___________________________________________________________________
Name: svn:mergeinfo
382390 + /branches/REL1_15/phase3/includes/Preferences.php:51646
/trunk/phase3/includes/Preferences.php:52290,52402,52404,52718,52737,52759,52762,52776,52791,52800,52808,52812-52813,52815-52819,52822,52846,52850,52852-52853,52855-52857,52859,52924,52986,53128-53129,53190,53197,53199,53203-53204,53210-53211,53247,53249,53252,53267,53270,53293,53305,53344,53369,53427,53502-53504,53506,53777,54384,54494,54592,54599-54602,54604,54613,54764,54793,54806,55178

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52762(bug 19468) $wgEnotifWatchlist disabled, but option available on preferencesdemon01:46, 4 July 2009

Status & tagging log