r55210 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55209‎ | r55210 | r55211 >
Date:22:22, 17 August 2009
Author:demon
Status:deferred
Tags:
Comment:
5.3 call time pass by ref errors.
Modified paths:
  • /trunk/extensions/SelectCategory/SelectCategoryFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SelectCategory/SelectCategoryFunctions.php
@@ -18,7 +18,7 @@
1919 function fnSelectCategoryShowHook( $m_isUpload = false, &$m_pageObj ) {
2020
2121 # check if we should do anything or sleep
22 - if ( fnSelectCategoryCheckConditions( $m_isUpload, &$m_pageObj ) ) {
 22+ if ( fnSelectCategoryCheckConditions( $m_isUpload, $m_pageObj ) ) {
2323 # Register CSS file for our select box:
2424 global $wgOut, $wgScriptPath;
2525 $wgOut->addLink(
@@ -100,7 +100,7 @@
101101 global $wgTitle;
102102
103103 # check if we should do anything or sleep
104 - if ( fnSelectCategoryCheckConditions( $m_isUpload, &$m_pageObj ) ) {
 104+ if ( fnSelectCategoryCheckConditions( $m_isUpload, $m_pageObj ) ) {
105105
106106 # Get localised namespace string:
107107 $m_catString = $wgContLang->getNsText( NS_CATEGORY );

Status & tagging log