r55209 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55208‎ | r55209 | r55210 >
Date:21:54, 17 August 2009
Author:catrope
Status:deferred
Tags:
Comment:
EditToolbar: Fix brokenness (or at least counter-intuitive behavior) in header row generation
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -558,7 +558,7 @@
559559 for ( var r = 0; r < rows; r++ ) {
560560 table += "|-\n";
561561 for ( var c = 0; c < cols; c++ ) {
562 - var isHeader = ( r < hrows && c < hcols );
 562+ var isHeader = ( r < hrows || c < hcols );
563563 var delim = isHeader ? '!' : '|';
564564 if ( c > 0 )
565565 delim += delim;
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php
@@ -19,7 +19,7 @@
2020 /* Configuration */
2121
2222 // Bump the version number every time you change any of the .css/.js files
23 -$wgEditToolbarStyleVersion = 26;
 23+$wgEditToolbarStyleVersion = 27;
2424
2525 // Set this to true to simply override the stock toolbar for everyone
2626 $wgEditToolbarGlobalEnable = false;

Status & tagging log