r55157 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55156‎ | r55157 | r55158 >
Date:20:56, 16 August 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 20274) Strict standards issue in 5.3.
Modified paths:
  • /trunk/phase3/includes/parser/Preprocessor_DOM.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Preprocessor_DOM.php
@@ -419,7 +419,8 @@
420420 'count' => $count );
421421 $stack->push( $piece );
422422 $accum =& $stack->getAccum();
423 - extract( $stack->getFlags() );
 423+ $flags = $stack->getFlags();
 424+ extract( $flags );
424425 $i += $count;
425426 }
426427 }
@@ -470,7 +471,8 @@
471472 // Unwind the stack
472473 $stack->pop();
473474 $accum =& $stack->getAccum();
474 - extract( $stack->getFlags() );
 475+ $flags = $stack->getFlags();
 476+ extract( $flags );
475477
476478 // Append the result to the enclosing accumulator
477479 $accum .= $element;
@@ -497,7 +499,8 @@
498500
499501 $stack->push( $piece );
500502 $accum =& $stack->getAccum();
501 - extract( $stack->getFlags() );
 503+ $flags = $stack->getFlags();
 504+ extract( $flags );
502505 } else {
503506 # Add literal brace(s)
504507 $accum .= htmlspecialchars( str_repeat( $curChar, $count ) );
@@ -597,9 +600,9 @@
598601 }
599602 $enclosingAccum .= str_repeat( $piece->open, $skippedBraces );
600603 }
 604+ $flags = $stack->getFlags();
 605+ extract( $flags );
601606
602 - extract( $stack->getFlags() );
603 -
604607 # Add XML element to the enclosing accumulator
605608 $accum .= $element;
606609 }

Status & tagging log