r55144 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55143‎ | r55144 | r55145 >
Date:15:32, 16 August 2009
Author:demon
Status:reverted (Comments)
Tags:
Comment:
Remove wgDeletedDirectory from the checked globals. Still needs implementation with $wgFileStore['deleted'] though.
Modified paths:
  • /branches/new-installer/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/Installer.php
@@ -29,7 +29,6 @@
3030 'wgScriptPath',
3131 'wgScriptExtension',
3232 'wgMetaNamespace',
33 - 'wgDeletedDirectory',
3433 'wgEnableUploads',
3534 'wgLogo',
3635 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r55292Revert r55144, re-add wgDeletedDirectory.demon00:19, 19 August 2009

Comments

#Comment by Tim Starling (talk | contribs)   02:50, 17 August 2009

The idea was to introduce $wgDeletedDirectory to the core, and to stop using $wgFileStore['deleted']. Installer variables just have identifiers as names and don't set array members, and $wgFileStore is obsolete anyway, existing only to set that one directory.

#Comment by 😂 (talk | contribs)   02:57, 17 August 2009

I like the idea of doing that, but right now it's just throwing a notice on each page, that was my main reason for removing it. I can re-add it commented out though.

Status & tagging log