r55013 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55012‎ | r55013 | r55014 >
Date:12:25, 14 August 2009
Author:werdna
Status:deferred
Tags:
Comment:
Bug 19760, swap expiry/reason fields to match ordering on regular block form
Modified paths:
  • /trunk/extensions/GlobalBlocking/SpecialGlobalBlock.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalBlocking/SpecialGlobalBlock.php
@@ -177,16 +177,7 @@
178178 $this->mAddress,
179179 array('id' => 'mw-globalblock-address' )
180180 );
181 -
182 - // Why to block them
183 - $fields['globalblocking-block-reason'] =
184 - Xml::input(
185 - 'wpReason',
186 - 45,
187 - $this->mReason,
188 - array( 'id' => 'mw-globalblock-reason' )
189 - );
190 -
 181+
191182 // How long to block them for
192183 if ( ( $dropdown = wfMsgNoTrans( 'globalblocking-expiry-options' ) ) != '-') {
193184 # Drop-down list
@@ -220,6 +211,15 @@
221212 array( 'id' => 'mw-globalblock-expiry-other' )
222213 );
223214 }
 215+
 216+ // Why to block them
 217+ $fields['globalblocking-block-reason'] =
 218+ Xml::input(
 219+ 'wpReason',
 220+ 45,
 221+ $this->mReason,
 222+ array( 'id' => 'mw-globalblock-reason' )
 223+ );
224224
225225 // Block all users, or just anonymous ones
226226 $fields['globalblocking-block-options'] =

Status & tagging log